Skip to content

[Doc] Fixed typos and improved cross-referencing in ppo tutorial #2490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2023

Conversation

MatteoGaetzner
Copy link
Contributor

@MatteoGaetzner MatteoGaetzner commented Jun 26, 2023

Fixes #2489

Description

In this pull request, I've made some changes to improve the clarity and ease of navigation within our documentation. Specifically, I've enhanced cross-referencing by updating the way certain class references are displayed. I replaced the previous format of ":class:SomeClass" with a more succinct and user-friendly format :class:~path.to.SomeClass. This new format hides the full path of the class and only displays the class name, while still linking to the correct location.

Additionally, I took the liberty of correcting some typographical errors scattered throughout the documentation, further improving readability.

Checklist

  • The issue that is being fixed is referred in the description (see above "Fixes #ISSUE_NUMBER")
  • Only one issue is addressed in this pull request
  • Labels from the issue that this PR is fixing are added to this pull request
  • No unnecessary issues are included into this pull request.

cc @svekars @carljparker @vmoens @nairbv

@pytorch-bot
Copy link

pytorch-bot bot commented Jun 26, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/2490

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b0b7123:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for pytorch-tutorials-preview ready!

Name Link
🔨 Latest commit b0b7123
🔍 Latest deploy log https://app.netlify.com/sites/pytorch-tutorials-preview/deploys/6499efff8bbdf50008f5b28e
😎 Deploy Preview https://deploy-preview-2490--pytorch-tutorials-preview.netlify.app/intermediate/reinforcement_ppo
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@vmoens vmoens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thanks a million for that
Can you also change the ref on line 19 while we're at it?
Thanks

- How to make your classes talk to each other using :class:`tensordict.TensorDict`;

@vmoens vmoens merged commit d68dfce into pytorch:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💡 [REQUEST] - Update to PPO Tutorial
4 participants